feat: support of injectHot and injectClient on specific chunks#2998
Open
paztis wants to merge 1 commit intowebpack:mainfrom
Open
feat: support of injectHot and injectClient on specific chunks#2998paztis wants to merge 1 commit intowebpack:mainfrom
paztis wants to merge 1 commit intowebpack:mainfrom
Conversation
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
+ Coverage 92.30% 92.33% +0.02%
==========================================
Files 37 37
Lines 1261 1278 +17
Branches 327 335 +8
==========================================
+ Hits 1164 1180 +16
- Misses 92 93 +1
Partials 5 5
Continue to review full report at Codecov.
|
Author
rebase done |
Member
|
Can you fix conflicts? |
Author
|
seems all my dev is to redo as webpack5 EntryPlugin management has been totally changed few days ago... |
Author
|
code updated, but all the unit test part has been removed. |
Author
|
rebase done |
Author
|
any news ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
In case of application with multiple iframes, only the top level frame has to listen socket for refresh
This PR add the support of chunk target in the injectClient and injectHot options. You are able to limit the client injection only in specific chunks
Resolving of #2969
Breaking Changes
Additional Info
none